Fix CheckBox and ToolBarSearchBox icon positioning.#10356
Merged
cjcenizal merged 3 commits intoelastic:masterfrom Feb 15, 2017
Merged
Fix CheckBox and ToolBarSearchBox icon positioning.#10356cjcenizal merged 3 commits intoelastic:masterfrom
cjcenizal merged 3 commits intoelastic:masterfrom
Conversation
cjcenizal
added
Team:Platform-Design
weltenwort
reviewed
Feb 15, 2017
| left: 8px; | ||
| top: 0.5em; | ||
| left: 0.7em; | ||
| font-size: 1em; |
Member
There was a problem hiding this comment.
This is immediately overridden by the next line.
Contributor
There was a problem hiding this comment.
Did you mean to merge this without pushing a fix for that?
Contributor
Author
There was a problem hiding this comment.
No, it was an accident. But it also doesn't have any effect on the UI so I cleaned it up in #10358 instead.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Feb 15, 2017
* Fix CheckBox alignment by applying box-sizing: border-box to all before and after pseudo-elements. * Fix ToolBarSearchBox height and icon alignment. * Make Table examples consistently use the cell liner.
cjcenizal
added a commit
that referenced
this pull request
Feb 15, 2017
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Feb 15, 2017
* Fix CheckBox alignment by applying box-sizing: border-box to all before and after pseudo-elements. * Fix ToolBarSearchBox height and icon alignment. * Make Table examples consistently use the cell liner.
cjcenizal
added a commit
that referenced
this pull request
Feb 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #10283
Note that this doesn't solve alignment problems when zoom is less than 100%. I think this might just be a problem with the way FontAwesome scales down.
Note: this PR only addresses icon positioning. The vertical alignment of the checkboxes and the text is off.